Documents: add responsive high-yield clinical summary#1169
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a dedicated clinical summary model and UI for document overviews, including profile-derived priorities, fallback content, disclosures, page navigation, and mobile presentation. Updates overview wiring and expands unit, DOM, and smoke-test coverage. ChangesClinical summary experience
Review ledger record
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant DocumentViewer
participant DocumentOverviewLanding
participant DocumentClinicalSummary
participant MobileSheet
DocumentViewer->>DocumentOverviewLanding: render overview
DocumentOverviewLanding->>DocumentClinicalSummary: pass document and navigation callbacks
DocumentClinicalSummary->>MobileSheet: open clinical priorities
MobileSheet->>DocumentClinicalSummary: activate page link
DocumentClinicalSummary->>DocumentViewer: call onPageChange(page)
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61da1b267d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd360d8924
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #4967 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
- Default missing pages arrays to [] before page lookup - Skip enrichment placeholder text in clinical summary display Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42abd25379
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/components/document-viewer/document-clinical-summary.tsx (2)
171-191: 📐 Maintainability & Code Quality | 🔵 TrivialClinical-output change — run the mandated domain check.
buildDocumentClinicalSummaryModelis new clinical-output derivation logic. As per path instructions, "For auth, Supabase, ingestion, answer generation, search/ranking, clinical output, or source-governance changes, run the smallest relevant domain check plusnpm run check:production-readiness."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/document-viewer/document-clinical-summary.tsx` around lines 171 - 191, The new clinical-output derivation in buildDocumentClinicalSummaryModel requires validation with the smallest relevant clinical domain check, followed by npm run check:production-readiness. Run both checks and resolve any failures without changing the intended summary and priorities behavior.Source: Path instructions
220-243: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
<Link>for the internal page navigation.
PriorityPageLinkrenders a raw internal<a href>with hand-rolled modifier-key/preventDefault logic. Replace it withLink from "next/link";onClickstill supportspreventDefault(), butLink’s dedicatedonNavigatehandler is better suited for client-side navigation guards because it only fires for client-side navigations.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/document-viewer/document-clinical-summary.tsx` around lines 220 - 243, Replace the raw anchor in PriorityPageLink with Next.js Link, importing Link from next/link and passing href to it. Move the page navigation guard to Link’s onNavigate handler, preserving preventDefault and onNavigate(page) behavior while removing the manual mouse-button and modifier-key checks.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 757: Update the date in the ledger row for commit
6bbce2b97477cb4497624abe2a37c74864e872c8 from 2026-07-25 to 2026-07-24,
preserving the remaining verification details unchanged.
---
Nitpick comments:
In `@src/components/document-viewer/document-clinical-summary.tsx`:
- Around line 171-191: The new clinical-output derivation in
buildDocumentClinicalSummaryModel requires validation with the smallest relevant
clinical domain check, followed by npm run check:production-readiness. Run both
checks and resolve any failures without changing the intended summary and
priorities behavior.
- Around line 220-243: Replace the raw anchor in PriorityPageLink with Next.js
Link, importing Link from next/link and passing href to it. Move the page
navigation guard to Link’s onNavigate handler, preserving preventDefault and
onNavigate(page) behavior while removing the manual mouse-button and
modifier-key checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c2cb669d-85c6-41ac-9def-b12a165cbcfc
📒 Files selected for processing (7)
docs/branch-review-ledger.mdsrc/components/DocumentViewer.tsxsrc/components/document-viewer/document-clinical-summary.tsxsrc/components/document-viewer/document-overview-landing.tsxtests/document-clinical-summary.dom.test.tsxtests/document-clinical-summary.test.tstests/ui-smoke.spec.ts
💤 Files with no reviewable changes (1)
- src/components/DocumentViewer.tsx
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b81bf488b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6a13ebce0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10bdf21efb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* docs(ledger): record babysit sweep for PRs #1124 #1131 #1146 #1157 #1162 #1167 #1169 #1170 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record open-PR conflict-resolution sweep and #1162 Bugbot Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record #1162 conflict resolution and Bugbot outcome Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record open-PR conflict sync (all mergeable) Merged origin/main into remaining behind/dirty PR heads so every open PR is MERGEABLE with behind=0. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): drop exact duplicate #1170 review row Remove the second identical PR #1170 ledger record so check:branch-review-ledger passes. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record open-PR conflict sync for 22 PRs Merged origin/main into every open PR head so all are current with main. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): drop exact duplicate review rows Remove duplicate ledger records so check:branch-review-ledger passes after the conflict sync. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: auto-sync open PR branches and clear postcss audit Add a main-push workflow and local helper that update behind PR heads so GitHub stops falsely marking the queue CONFLICTING/DIRTY after each land. Bump postcss to a non-vulnerable release so Safety npm audit stays green. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
2 participants
Summary
fields=index, differentials abort/debounce, universal documents typeahead soft-timeout (750ms), shared(search-app)shell to avoid composer remount, and Answer rate-limit in-memory fallback outside production./services→/dsm) syncssearchModeduring render (no stale-mode paint) even when the query string is unchanged; extracted ClinicalDashboard lazy imports to stay under the maintainability budget.RAG impact: no retrieval behaviour change — typeahead documents domain timeout and shell URL sync only; ranking formulas and full
/api/searchretrieval path unchanged.Verification
npm run verify:pr-local— focused Vitest on touched sources (362) plus api-rate-limit / search-shell / universal / route / site-map suites green;docs:check-indexOKverify:uinot required for this pass; mode-home smoke vianpm run ensurereturned HTTP 200 for/,/services,/dsm,/documents/search,/therapy-compass,/?mode=prescribing, and/api/answer/streamreturned 200 after the rate-limit fallback fixeval:retrieval:latency/ soak / live OpenAI canary — approval-gated provider work; not needed for timeout-only typeahead changeRisk and rollout
GlobalSearchShelllayouts and prior timeout/fallback behaviourClinical Governance Preflight
[REDACTED]([REDACTED])Notes
fields=indexremains for identity-only consumers (cross-mode links).